Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate destinations URLs in frontend before saving #73

Closed
edeNFed opened this issue Feb 14, 2023 · 3 comments
Closed

Validate destinations URLs in frontend before saving #73

edeNFed opened this issue Feb 14, 2023 · 3 comments
Labels
enhancement New feature or request frontend good first issue Good for newcomers

Comments

@edeNFed
Copy link
Contributor

edeNFed commented Feb 14, 2023

Currently, the only validation the frontend performs is that the destination URL is a valid URL.
We can help users avoid typing the wrong URLs by performing more validations in the frontend before persisting the destination.
Examples of possible additional validations:

  • Elasticsearch: URL should contain port 9200
  • Generic OTLP: URL should contain port 4317
  • Datadog: URL should be a valid site
  • and many more, we can probably think of a better validation for every destination.

The first step in implementing this issue may be just validating a single destination in addition to thinking about a good design for validations in frontend.

@edeNFed edeNFed added enhancement New feature or request good first issue Good for newcomers frontend labels Feb 14, 2023
@D-Lite
Copy link
Contributor

D-Lite commented Apr 7, 2023

Hi @edeNFed , is this issue still open? I will like to pick it up and resolve it. I am more interested about FE related issues on Open Source projects!

@D-Lite
Copy link
Contributor

D-Lite commented Apr 14, 2023

Odigos.FE.validation.-.Made.with.Clipchamp.mp4

I was able to come up with an FE validation for the Elasticsearch and Generic OTLF urls.
Implementation was based on testing the URLs on the frontend against a regex pattern

@D-Lite
Copy link
Contributor

D-Lite commented Apr 28, 2023

This issue should be closed @edeNFed

@edeNFed edeNFed closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants