-
Notifications
You must be signed in to change notification settings - Fork 196
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[GEN-1484] fix: select all checkbox bug (#1579)
This pull request introduces pagination support across multiple tables in the frontend web application. The key changes include adding state management for current page and items per page, updating components to handle these new states, and modifying existing functions to utilize pagination. ### Pagination Support: * [`frontend/webapp/components/overview/actions/actions.table/index.tsx`](diffhunk://#diff-68fd71cdfc34b7216566e69fddcb9f1f49a52cf60ae0bb9cfa0a34866f18653bR27-R28): Added state management for `currentPage` and `itemsPerPage` and passed these states to the table component. [[1]](diffhunk://#diff-68fd71cdfc34b7216566e69fddcb9f1f49a52cf60ae0bb9cfa0a34866f18653bR27-R28) [[2]](diffhunk://#diff-68fd71cdfc34b7216566e69fddcb9f1f49a52cf60ae0bb9cfa0a34866f18653bR79-R82) * [`frontend/webapp/components/overview/destination/managed.destination.table/index.tsx`](diffhunk://#diff-1858ab526c25ec82399b7f0f60fc2525286cfc4ce294d1c83b309cdbb08f8e6aL1-R1): Added state management for `currentPage` and `itemsPerPage` and passed these states to the table component. [[1]](diffhunk://#diff-1858ab526c25ec82399b7f0f60fc2525286cfc4ce294d1c83b309cdbb08f8e6aL1-R1) [[2]](diffhunk://#diff-1858ab526c25ec82399b7f0f60fc2525286cfc4ce294d1c83b309cdbb08f8e6aR22-R23) [[3]](diffhunk://#diff-1858ab526c25ec82399b7f0f60fc2525286cfc4ce294d1c83b309cdbb08f8e6aR51-R54) * [`frontend/webapp/components/overview/instrumentation-rules/rules-table/index.tsx`](diffhunk://#diff-d3010b5cf16d53be999be2079d267fa07aba3210366d23ef37440ad491216cdaR18-R19): Added state management for `currentPage` and `itemsPerPage` and passed these states to the table component. [[1]](diffhunk://#diff-d3010b5cf16d53be999be2079d267fa07aba3210366d23ef37440ad491216cdaR18-R19) [[2]](diffhunk://#diff-d3010b5cf16d53be999be2079d267fa07aba3210366d23ef37440ad491216cdaR43-R46) * [`frontend/webapp/components/overview/sources/managed.sources.table/index.tsx`](diffhunk://#diff-4020f76a2fe3ae08af9a10d765da811540ea691abbd6b5e57c8197fa12798aafR40-R41): Added state management for `currentPage` and `itemsPerPage`, updated functions to use these states, and passed them to the table component. [[1]](diffhunk://#diff-4020f76a2fe3ae08af9a10d765da811540ea691abbd6b5e57c8197fa12798aafR40-R41) [[2]](diffhunk://#diff-4020f76a2fe3ae08af9a10d765da811540ea691abbd6b5e57c8197fa12798aafL67-R70) [[3]](diffhunk://#diff-4020f76a2fe3ae08af9a10d765da811540ea691abbd6b5e57c8197fa12798aafR94-R97) [[4]](diffhunk://#diff-4020f76a2fe3ae08af9a10d765da811540ea691abbd6b5e57c8197fa12798aafR113) [[5]](diffhunk://#diff-4020f76a2fe3ae08af9a10d765da811540ea691abbd6b5e57c8197fa12798aafR147-R150) * [`frontend/webapp/components/overview/sources/managed.sources.table/sources.table.header.tsx`](diffhunk://#diff-adff0f1794275ca642a1b8a03d581c0aebd93b16ee29be4f29c9944a9b1bac2eR66): Updated the header component to use `currentItems` for checkbox selection logic. [[1]](diffhunk://#diff-adff0f1794275ca642a1b8a03d581c0aebd93b16ee29be4f29c9944a9b1bac2eR66) [[2]](diffhunk://#diff-adff0f1794275ca642a1b8a03d581c0aebd93b16ee29be4f29c9944a9b1bac2eR81) [[3]](diffhunk://#diff-adff0f1794275ca642a1b8a03d581c0aebd93b16ee29be4f29c9944a9b1bac2eL386-R391) ### Table Component Enhancements: * [`frontend/webapp/design.system/table/index.tsx`](diffhunk://#diff-5c3a89905dd42cf2979a509e79652fb54c0f3bb7bda51c457f17043661370a18R11-R14): Updated the `TableProps` type to include `currentPage`, `itemsPerPage`, `setCurrentPage`, and `setItemsPerPage` properties. ### Dependency Update: * [`frontend/webapp/package.json`](diffhunk://#diff-ccf6337b0064354343f900ffd8b4ee91aa8cd014f3292548a800ad3dac39c1f4L14-R14): Updated `@keyval-dev/design-system` dependency to version `^2.3.3`.
- Loading branch information
1 parent
ce6e4c1
commit 741d664
Showing
8 changed files
with
47 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters