Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: match file names in helm registry index and release assets (#1373)
Adding a separate Helm chart for CRDs. :exclamation: The charts are not strictly dependent to one another and need to be separately managed and installed. Meaning we need to document that both of those need to be updated and installed. Fair questions that might arise: **Why isn't CRD chart a declared dependency for `odigos`?** Helm merges dependent resources together with the ones from dependencies. We'd be exactly where we are right now if we did that. **Why not use the official `crd` support?** Helm really doesn't "support" CRDs. It's an opt-out feature of "we don't know how we want to do it so we don't for now". Resources declared as CRDs(different from declaring them under `templates`) are not updated. **How do other charts do it then?** All charts I've encountered(cert-manager, jaeger, contour) have CRDs under a flag and include them in the same chart as the rest of the resources **but then** do not depend on them in in the install. CRs are created either only by the user or later in the applications life-cycle. This doesn't work for us since we declare Odigos Config among resources in the application chart. That begs the question whether Odigos Config must be a CR at all or could it be a config map instead - we wouldn't get "type-checking" by k8s API but would gain some flexibility and could release our charts as one.
- Loading branch information