Skip to content
This repository was archived by the owner on Mar 8, 2021. It is now read-only.

concat scripts to a single file #18

Open
wants to merge 1 commit into
base: extension
Choose a base branch
from

Conversation

Scrxtchy
Copy link

Not really much point in adding complexity to the build operation when you can just use a test what browser someone is using and alter the operation based on that condition.

Build script may need testing, I believe my version of zip behaves differently, you could forgo the build version folder entirely if you wanted seeing there's now only single output

@vercel
Copy link

vercel bot commented Nov 26, 2020

@Scrxtchy is attempting to deploy a commit to a Personal Account owned by @odensc on Vercel.

@odensc first needs to authorize it.

@odensc
Copy link
Owner

odensc commented Nov 28, 2020

Is there a better way of checking the browser besides detecting chrome.app?

@Scrxtchy
Copy link
Author

There's a few other ways, but you're really just going to check if any of these functions exist or not.
Firefox has a runtime.getBrowserInfo() which returns an Promise if you want to do string compare, but this function doesn't appear to exist within chrome's runtime api.

An old way of checking was to check if the chrome api was undefined on firefox, but this now exists on the platform for porting assistance (the browser standard api uses Promises)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants