-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename webnative to odd #506
Conversation
Yes please 👍
|
README.md
Outdated
case webnative.ProgramError.InsecureContext: | ||
// Webnative requires HTTPS | ||
case odd.ProgramError.InsecureContext: | ||
// ODD requires HTTPS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When 'ODD' is used on its own (eg. not ODD Program), should we say ODD.js or ODD SDK instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point. I think the distinction here is ODD SDK when used as a noun, and ODD when used as an adjective. I'll update the noun spots. 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, I've been using ODD SDK
for those cases in the new odd.dev site too 👍🏼
Note that this will still publish to webnative.fission.app for the moment.
Just flagging that we'll want to change the workflow urls too once those domains are ready https://github.com/fission-codes/webnative/blob/rename-webnative-to-odd/.github/workflows/docs.yaml#L33 |
Yep, good call. I'm not entirely sure how we have this set up to publish. @walkah could we look into updating this workflow URL to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I'm going to start integrating this branch with a few of the webnative
->odd
branches i have going in the different template repos 👍🏼
Updated this to |
Summary
This PR renames Webnative to ODD with the following changes:
webnative
to@oddjs/odd
webnative-walletauth
toodd-walletauth
at https://github.com/oddsdk/odd-walletauthwebnative-app-template
toodd-app-template
at https://github.com/oddsdk/odd-app-templateglobalThis.__webnative.programs
toglobalThis.__odd.programs
oddjs
instead ofwebnative
webnative
tooddjs
Webnative SDK
toODD SDK
sharedRepo
tofalse
odd.fission.app
Note that the docs are still published toThe docs have been updated to publish towebnative.fission.app
and we will point https://api.odd.dev to that for the moment.odd.fission.app
.What's missing?
WNFS has not been renamed yet. Can we and should we reframe this to use the term ODD Volumes?
There are a couple of places where there are breaking changes in the interaction with the lobby and the names of IndexedDB keys. These have been addressed based on PR feedback below:https://github.com/fission-codes/webnative/blob/27842451b01510a46524b35d997627c3fdc844c9/src/index.ts#L865-L867
Left this as is because it is for backwards compatibility.
https://github.com/fission-codes/webnative/blob/27842451b01510a46524b35d997627c3fdc844c9/src/components/capabilities/implementation/fission-lobby.ts#L97
Set
sharedRepo
tofalse
.https://github.com/fission-codes/webnative/blob/27842451b01510a46524b35d997627c3fdc844c9/src/components/capabilities/implementation/fission-lobby.ts#L157
https://github.com/fission-codes/webnative/blob/27842451b01510a46524b35d997627c3fdc844c9/src/components/capabilities/implementation/fission-lobby.ts#L204-L207
These last two have been renamed from
webnative
toodd
.Test plan (required)
The usual test suites should run as before because this is mostly about renaming.
Closing issues
Closes #505
Closes #507
After Merge