Replace TinyColor with Colorjs.io #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgerigmeyer
commented
Sep 8, 2022
|
Shucks, it looks like colorjs.io doesn't currently support Node v14, but they plan to:
We could wait for that, contribute a PR there, or drop Node v14 support... |
I don't really know the tradeoffs. How difficult to submit that PR? |
|
* main: Add note to color doc clean up example review add example with custom properties
✅ Deploy Preview for herman-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mirisuzanne
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TinyColor does not support colors that use hue angle notation (e.g.
hsl(53deg 89% 96%)), so when Sass started adding that by default, we lost the display values for those colors.