color is legacy #4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,182 @@ | ||||||
| <===> options.yml | ||||||
| --- | ||||||
| :ignore_for: | ||||||
| - libsass | ||||||
|
|
||||||
| <===> | ||||||
| =================================================================== | ||||||
| <===> rgb/input.scss | ||||||
SondraE marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(rgb(0 255 0))} | ||||||
|
|
||||||
| <===> rgb/output.css | ||||||
| a { | ||||||
| b: true; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> hwb/input.scss | ||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(hwb(0, 50%, 0%))} | ||||||
|
There was a problem hiding this comment.
Suggested change
I believe Sass will support with or without commas |
||||||
|
|
||||||
| <===> hwb/output.css | ||||||
| a { | ||||||
| b: true; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> hsl/input.scss | ||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(hsl(110, 31%, 32%))} | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| <===> hsl/output.css | ||||||
| a { | ||||||
| b: true; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> srgb/input.scss | ||||||
|
There was a problem hiding this comment. At some point we'll have to decide which of this need to be included to feel like we've covered enough cases. We probably won't need to test all of the color types. |
||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(srgb(115, 20, 210))} | ||||||
|
There was a problem hiding this comment. @mirisuzanne @dvdherron I've not really come across a lot with srgb used in a css notation like this before, but would it be more like: There was a problem hiding this comment. https://css.oddbird.net/sass/color-spaces/proposal/#predefined-color-spaces
|
||||||
|
|
||||||
| <===> srgb/output.css | ||||||
| a { | ||||||
| b: false; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> srgb-linear/input.scss | ||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(?????)} | ||||||
|
There was a problem hiding this comment. @mirisuzanne @dvdherron @SondraE and same for here? a {b: color.is-legacy(color(srgb-linear 0.45098 0.07843 0.823530))} |
||||||
|
|
||||||
| <===> srgb-linear/output.css | ||||||
| a { | ||||||
| b: false; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> display-p3/input.scss | ||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy((display-p3 0.515 0.35 0.3 / 1))} | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| <===> display-p3/output.css | ||||||
| a { | ||||||
| b: false; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> a98-rgb/input.scss | ||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(?????)} | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| <===> a98-rgb/output.css | ||||||
| a { | ||||||
| b: false; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> prophoto-rgb/input.scss | ||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(?????)} | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| <===> prophoto-rgb/output.css | ||||||
| a { | ||||||
| b: false; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> rec2020/input.scss | ||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(?????)} | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| <===> rec2020/output.css | ||||||
| a { | ||||||
| b: false; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> xyz/input.scss | ||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(xyz(0.0426 0.0442 0.0364))} | ||||||
|
|
||||||
| <===> xyz/output.css | ||||||
| a { | ||||||
| b: false; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> xyz-d50/input.scss | ||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(?????)} | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| <===> xyz-d50/output.css | ||||||
| a { | ||||||
| b: false; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> xyz-d65/input.scss | ||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(?????)} | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| <===> xyz-d65/output.css | ||||||
| a { | ||||||
| b: false; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> lab/input.scss | ||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(lab(5 110 115))} | ||||||
|
|
||||||
| <===> lab/output.css | ||||||
| a { | ||||||
| b: false; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> lch/input.scss | ||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(lch(90.6 52.8 197))} | ||||||
|
|
||||||
| <===> lch/output.css | ||||||
| a { | ||||||
| b: false; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> oklab/input.scss | ||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(oklab(0.44027, 0.08818, -0.13386))} | ||||||
|
There was a problem hiding this comment.
Suggested change
I believe the commas would be an error for oklab, oklch,lab, and lch |
||||||
|
|
||||||
| <===> oklab/output.css | ||||||
| a { | ||||||
| b: false; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
| ================================================================================ | ||||||
| <===> oklch/input.scss | ||||||
| @use "sass:color"; | ||||||
| a {b: color.is-legacy(oklch(70% 0.1 200))} | ||||||
|
|
||||||
| <===> oklch/output.css | ||||||
| a { | ||||||
| b: false; | ||||||
| } | ||||||
|
|
||||||
| <===> | ||||||
|
There was a problem hiding this comment. @SondraE I think this is the beginning of a new file so line 182 here can be removed (unless you are adding more of course). |
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SondraE I don't know this for sure, but I am guessing the filename
is_legacy.hrxwould be preferred.