-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anchor Positioning yearbook example #742
Conversation
View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..anchor-positioning-examples |
* main: Fix ports for localias on Windows Review Adjust ports to use localias Update project dates Update content/blog/2024/anchor-position-polyfill-2.md Bump the npm-minor-upgrades group with 2 updates Automated webmentions update Work in State of CSS review More review Apply suggestions from code review Add anchor-position polyfill update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Capitalize the first letter of each word in the title
- Alternative punctuation suggestion for easier reading: "...existing possibilities, and – don’t misunderstand me – anchor positioning..."
- For the final paragraph, could we use the bullet-pointed layout for the hire us and sponsor us CTAs – the layout we used on the article you published yesterday?
And if you're excited to use anchor positioning before it becomes baseline, | ||
check out our [polyfill](https://github.com/oddbird/css-anchor-positioning). It | ||
supports enough of the anchor positioning spec to do most things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth some discussion of why the demo doesn't use the polyfill. That was confusing to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it to include the polyfill, and also added a note on anchor-scope not being polyfilled or present in Chromium 125-130.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great article. I tried it with logical properties and couldn't get it work in Safari nor Chrome 130 and then we had a discussion during standup about why it won't work with the browser I tried it on. Do we want to add any further disclaimers about anything here?
Description
A walkthrough of a Yearbook layout
Related Issue(s)
#743
https://deploy-preview-742--oddleventy.netlify.app/2024/11/18/anchor-position-yearbook/