Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make highlighted resource post types plural #456

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Make highlighted resource post types plural #456

merged 3 commits into from
Nov 27, 2023

Conversation

dvdherron
Copy link
Contributor

Steps to test/reproduce

Navigate to /tags/ and see the highlighted resource types at the top of the list

Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).

Show me

image

Provide screenshots/animated gifs/videos if necessary.

Copy link

View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..plural-tags

@dvdherron
Copy link
Contributor Author

@dvdherron
Copy link
Contributor Author

dvdherron commented Nov 24, 2023

@mirisuzanne @jgerigmeyer I can't tell yet if this is some Firefox bug or due to something we've changed recently but some pages are initially loading in one column. Resizing the window or refreshing the page shows everything as expected. I haven't been able to replicate this in Chrome. This is what I see using FF 121.0 Beta 2 (20231122091904)

Both of these screen captures are from the latest version of Firefox Beta. The first one is from our live site. The second is from this deploy preview.

Posts.by.Tag._.OddBird.Mozilla.Firefox.2023-11-25.00-31-15.mp4
posts.mp4

* main:
  Automated webmentions update
  Automated dependency upgrades
Copy link
Member

@mirisuzanne mirisuzanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jgerigmeyer jgerigmeyer merged commit 491c7e8 into main Nov 27, 2023
9 checks passed
@jgerigmeyer jgerigmeyer deleted the plural-tags branch November 27, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants