Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output validation/upload logging #691

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Dec 17, 2024

Contents (#691)

Enhancements

  • Improve output validation/upload logging

Fixes

  • Avoid attempting to upload output manifest if it's None

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (9092646) to head (2a5a0f7).
Report is 104 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
+ Coverage   94.50%   94.66%   +0.16%     
==========================================
  Files          83       83              
  Lines        3547     3598      +51     
==========================================
+ Hits         3352     3406      +54     
+ Misses        195      192       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortadocodes cortadocodes self-assigned this Dec 17, 2024
@cortadocodes cortadocodes merged commit 12c120a into main Dec 17, 2024
5 checks passed
@cortadocodes cortadocodes deleted the improve-output-manifest-handling branch December 17, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants