Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: set node versions to lts/*, replace ts-node with tsx #1115

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Feb 24, 2025

Resolves #ISSUE_NUMBER

ts-node is not very well maintained currently and needs workarounds for ESM usage.
tsx just works out of the box


Before the change?

  • Workflows would use pinned versions of Node, while they weren't dependant on any specific version
  • Used ts-node to run scripts

After the change?

  • Workflows will now use the latest lts release of Node
  • Use tsx to run script

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

ts-node is not very well maintained currrently as needs workarounds for ESM usage.
TSX just works out of the box
@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Feb 24, 2025
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

nickfloyd
nickfloyd previously approved these changes Feb 27, 2025
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@wolfy1339 wolfy1339 enabled auto-merge (squash) February 27, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants