Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v20 #305

Merged
merged 16 commits into from
Jul 11, 2023
Merged

feat: v20 #305

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a1b57cb
ci: stop testing against NodeJS v14, v16 (#294)
wolfy1339 Jun 3, 2023
eb51114
fix(deps): update dependency @octokit/plugin-paginate-rest to v7 (#306)
renovate[bot] Jun 3, 2023
f94d470
Merge remote-tracking branch 'origin/main' into beta
nickfloyd Jun 27, 2023
d15ee6b
Updates package-lock
nickfloyd Jun 27, 2023
eed5428
fix(deps): bump octokit deps
wolfy1339 Jul 10, 2023
ca9b795
fix(deps): upgrade octokit deps
wolfy1339 Jul 10, 2023
6b5d630
Merge branch 'main' into beta
wolfy1339 Jul 10, 2023
f24b1fa
ci: remove hardcoded node version from `test` workflow
wolfy1339 Jul 10, 2023
a188352
build: use `@gr2m/fetch-mock`
wolfy1339 Jul 10, 2023
b474f9f
ci: bump `node-version` to 18
wolfy1339 Jul 10, 2023
ea492c2
test: skip custom client certificate test
wolfy1339 Jul 10, 2023
06518e7
build(deps): add missing `devDependency` on `nock`
wolfy1339 Jul 10, 2023
deb7566
test: replace usage of deprecated method
wolfy1339 Jul 10, 2023
81d17e0
test: remove unused import
wolfy1339 Jul 10, 2023
8a9a24e
test: rewrite agent-ca tests with undici
wolfy1339 Jul 10, 2023
6f472b0
test: use `JSON.stringify()` as a workaround for now
wolfy1339 Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions test/scenarios/errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,16 @@ describe("api.github.com", () => {
expect(error.message).toEqual(
`Validation Failed: {"resource":"Label","code":"invalid","field":"color"}`,
);
expect(error.response.data.errors).toStrictEqual([
{
resource: "Label",
code: "invalid",
field: "color",
},
]);
// To-Do: Figure out why the objects are not strictly equal
expect(JSON.stringify(error.response.data.errors)).toStrictEqual(
JSON.stringify([
{
resource: "Label",
code: "invalid",
field: "color",
},
]),
);
Comment on lines +27 to +36
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same situation as in octokit/core.js#563

octokit/core.js#563 (comment)

This will need to be handled in a follow-up issue

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 FAIL  test/scenarios/errors.test.ts
  ● api.github.com › (#684) errors-test

    expect(received).toStrictEqual(expected) // deep equality

    Expected: [{"code": "invalid", "field": "color", "resource": "Label"}]
    Received: serializes to the same string

      25 |           `Validation Failed: {"resource":"Label","code":"invalid","field":"color"}`,
      26 |         );
    > 27 |         expect(error.response.data.errors).toStrictEqual([
         |                                            ^
      28 |           {
      29 |             resource: "Label",
      30 |             code: "invalid",

      at test/scenarios/errors.test.ts:27:44

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in octokit/core.js#588

expect(error.response.data.documentation_url).toMatch(
new RegExp("rest/reference/issues#create-a-label"),
);
Expand Down