Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new apps endpoint #932

Merged
merged 7 commits into from
Sep 27, 2017
Merged

Add new apps endpoint #932

merged 7 commits into from
Sep 27, 2017

Conversation

seejohnrun
Copy link
Contributor

@seejohnrun seejohnrun commented Sep 14, 2017 •
edited
Loading

Adds find_installation_repositories_for_user

Replacement for #904

Will add VCR once we're settled.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 99.249% when pulling c27c119 on seejohnrun:add_apps_user_endpoints into 3076c0f on octokit:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 99.249% when pulling c27c119 on seejohnrun:add_apps_user_endpoints into 3076c0f on octokit:master.

kytrinyx
kytrinyx reviewed Sep 14, 2017
View reviewed changes
spec/octokit/client/apps_spec.rb Outdated
@@ -49,6 +49,14 @@
end
end # .installation

describe ".find_installation_repositories_for_user", :vcr do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need to pass the :vcr option here.

kytrinyx
kytrinyx suggested changes Sep 14, 2017
View reviewed changes
Copy link
Contributor

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the minor comment, this looks great! Requesting changes so that we're reminded to check back once the VCR cassettes are added.

Thanks.

@coveralls
Copy link

coveralls commented Sep 14, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.0004%) to 99.249% when pulling 65d7935 on seejohnrun:add_apps_user_endpoints into 3076c0f on octokit:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 99.249% when pulling ed4de51 on seejohnrun:add_apps_user_endpoints into 3076c0f on octokit:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 99.249% when pulling ed4de51 on seejohnrun:add_apps_user_endpoints into 3076c0f on octokit:master.

seejohnrun added a commit to seejohnrun/octokit.rb that referenced this pull request Sep 15, 2017
@seejohnrun
Fix spec for find_user_installations
9cb496e 
While working on VCR for octokit#932,
I noticed that this other endpoint had a VCR entry that didn't
correspond to the real response format.

This fixes the test and updates the VCR cassette.
@seejohnrun seejohnrun mentioned this pull request Sep 15, 2017
Merged
@seejohnrun
Copy link
Contributor Author

what do you think @kytrinyx ?

kytrinyx
kytrinyx approved these changes Sep 27, 2017
View reviewed changes
Copy link
Contributor

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks good. I've pointed out a ridiculously minor typo in the doc comment.

lib/octokit/client/apps.rb Outdated

# List repositories accessible to the user for an installation
#
# @param installation [Integer] The id of a a GitHub App Installation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a" is here twice.

@seejohnrun
Copy link
Contributor Author

@kytrinyx Fixed that another another grammatical error that were present in multiple places in this file - thanks!

@coveralls
Copy link

coveralls commented Sep 27, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 99.25% when pulling 400c6f4 on seejohnrun:add_apps_user_endpoints into 3076c0f on octokit:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.25% when pulling 400c6f4 on seejohnrun:add_apps_user_endpoints into 3076c0f on octokit:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.25% when pulling 400c6f4 on seejohnrun:add_apps_user_endpoints into 3076c0f on octokit:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 99.25% when pulling b7942f2 on seejohnrun:add_apps_user_endpoints into 684a2ae on octokit:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 99.25% when pulling b7942f2 on seejohnrun:add_apps_user_endpoints into 684a2ae on octokit:master.

@tarebyte tarebyte merged commit e923472 into octokit:master Sep 27, 2017
@kytrinyx kytrinyx mentioned this pull request Dec 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kytrinyx kytrinyx kytrinyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seejohnrun @coveralls @kytrinyx @tarebyte