Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Octokit::Client::Apps#find_user_installations method #895

Merged
merged 4 commits into from
Aug 21, 2017
Merged

Add Octokit::Client::Apps#find_user_installations method #895

merged 4 commits into from
Aug 21, 2017

Conversation

greysteil
Copy link
Contributor

@greysteil greysteil commented May 30, 2017

Specs will fail as I haven't added a cassette. Can someone who already has the required environment variable set up do so?

@coveralls
Copy link

coveralls commented May 30, 2017

Coverage Status

Coverage increased (+0.0004%) to 99.274% when pulling 5aed8a4 on greysteil:add-find-user-installations into c3aa3e0 on octokit:master.

@greysteil
Copy link
Contributor Author

@tarebyte - any chance you could do me the honour of a cassette?

@coveralls
Copy link

coveralls commented Aug 21, 2017

Coverage Status

Coverage increased (+0.002%) to 99.276% when pulling 3eb5b17 on greysteil:add-find-user-installations into c3aa3e0 on octokit:master.

@coveralls
Copy link

coveralls commented Aug 21, 2017

Coverage Status

Coverage increased (+0.0003%) to 99.276% when pulling cd212f7 on greysteil:add-find-user-installations into 0f13944 on octokit:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 99.276% when pulling adbd332 on greysteil:add-find-user-installations into 0f13944 on octokit:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 99.276% when pulling adbd332 on greysteil:add-find-user-installations into 0f13944 on octokit:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 99.276% when pulling adbd332 on greysteil:add-find-user-installations into 0f13944 on octokit:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 99.276% when pulling adbd332 on greysteil:add-find-user-installations into 0f13944 on octokit:master.

@greysteil
Copy link
Contributor Author

Now with passing cassette (I cheated, and borrowed the one for find_app_installations which has an identical response).

Bumped the Ruby 2.4 version on travis as I was getting segfaults on 2.4.0.

@coveralls
Copy link

coveralls commented Aug 21, 2017

Coverage Status

Coverage increased (+0.0003%) to 99.276% when pulling c778ea2 on greysteil:add-find-user-installations into 0f13944 on octokit:master.

@tarebyte tarebyte merged commit 19482da into octokit:master Aug 21, 2017
@tarebyte tarebyte deleted the add-find-user-installations branch August 21, 2017 12:56
@greysteil
Copy link
Contributor Author

🎉

@kytrinyx kytrinyx mentioned this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants