Skip to content

Commit

Permalink
rubocop fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
nickfloyd committed Sep 29, 2023
1 parent 211d35a commit 733b5b5
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 22 deletions.
2 changes: 1 addition & 1 deletion lib/octokit/client/apps.rb
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ def delete_installation(installation, options = {})
#
# @return [Array<Hash>] an array of hook deliveries
def list_app_hook_deliveries(options = {})
paginate("app/hook/deliveries", options) do |data, last_response|
paginate('app/hook/deliveries', options) do |data, last_response|
data.concat last_response.data
end
end
Expand Down
41 changes: 20 additions & 21 deletions spec/octokit/client/apps_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -182,29 +182,29 @@
end
end # .find_user_installation

describe '.list_app_hook_deliveries', :vcr do
it 'lists hook deliveries for an app' do
response = @jwt_client.list_app_hook_deliveries
expect(response).to be_kind_of(Array)
expect(response.count).to eq 2
end
describe '.list_app_hook_deliveries', :vcr do
it 'lists hook deliveries for an app' do
response = @jwt_client.list_app_hook_deliveries
expect(response).to be_kind_of(Array)
expect(response.count).to eq 2
end

it 'allows auto_pagination' do
@jwt_client.auto_paginate = true
response = @jwt_client.list_app_hook_deliveries(per_page: 1)
it 'allows auto_pagination' do
@jwt_client.auto_paginate = true
response = @jwt_client.list_app_hook_deliveries(per_page: 1)

expect(response).to be_kind_of(Array)
expect(response.count).to eq 3
end
end #.list_app_hook_deliveries
expect(response).to be_kind_of(Array)
expect(response.count).to eq 3
end
end # .list_app_hook_deliveries

describe '.deliver_app_hook', :vcr do
let(:delivery_id) { 55148726666 }
it 'schedules a webhook for redelivery' do
response = @jwt_client.deliver_app_hook(delivery_id)
expect(response).to be_truthy
end
end #.deliver_app_hook
describe '.deliver_app_hook', :vcr do
let(:delivery_id) { 55_148_726_666 }
it 'schedules a webhook for redelivery' do
response = @jwt_client.deliver_app_hook(delivery_id)
expect(response).to be_truthy
end
end # .deliver_app_hook

context 'with app installation', :vcr do
let(:installation) { test_github_integration_installation }
Expand Down Expand Up @@ -302,7 +302,6 @@
end
end # .delete_installation


context 'with app installation access token' do
let(:installation_client) do
token = @jwt_client.create_app_installation_access_token(installation).token
Expand Down

0 comments on commit 733b5b5

Please sign in to comment.