Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify operationName in multi-operation queries #629

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

klippx
Copy link
Contributor

@klippx klippx commented Jan 31, 2025

Resolves #406

Related types PR: octokit/types.ts#662


Before the change?

  • It was not possible to send a query with multiple operations

After the change?

  • Sending a query with multiple operations
  • Specifying to the server which operation to use

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@klippx klippx changed the title Add test describing current functionality Allow users to specify operationName in multi-operation queries Jan 31, 2025
@wolfy1339
Copy link
Member

Once the new version of @octokit/types is released, can you update it here

@klippx
Copy link
Contributor Author

klippx commented Jan 31, 2025

Updated @octokit/types

@wolfy1339 wolfy1339 merged commit 9a1787e into octokit:main Jan 31, 2025
7 checks passed
Copy link

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@klippx klippx deleted the operation-name branch February 1, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"An operation name is required if the query contains multiple operations"
2 participants