Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg): add main entry point #662

Merged
merged 2 commits into from
Feb 26, 2024
Merged

fix(pkg): add main entry point #662

merged 2 commits into from
Feb 26, 2024

Conversation

deniak
Copy link
Contributor

@deniak deniak commented Feb 26, 2024

Before the change?

Now that the package is ESM, eslint may return the following errors:

error  Unable to resolve path to module '@octokit/core'  import/no-unresolved
error  "@octokit/core" is not found                      node/no-missing-import

After the change?

eslint should no longer report the errors

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

…rror `Unable to resolve path to module '@octokit/core'`
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

I wonder why that is.

Shouldn't the export field be enough?

@deniak
Copy link
Contributor Author

deniak commented Feb 26, 2024

I wonder why that is.

Shouldn't the export field be enough?

I thought so too, but eslint started complaining after the upgrade to 6.0.0 :(

@wolfy1339
Copy link
Member

Can you add the type parameter as well for good measure

@deniak
Copy link
Contributor Author

deniak commented Feb 26, 2024

Can you add the type parameter as well for good measure

You mean the "type": "module"?
Isn't it there already (https://github.com/octokit/core.js/blob/main/package.json#L7)?

@wolfy1339
Copy link
Member

Sorry, I meant types

@deniak
Copy link
Contributor Author

deniak commented Feb 26, 2024

Sorry, I meant types

Sure, I just committed the update.

@wolfy1339 wolfy1339 changed the title add main entry point fix(pkg): add main entry point Feb 26, 2024
@wolfy1339 wolfy1339 merged commit 42148fc into octokit:main Feb 26, 2024
7 checks passed
Copy link
Contributor

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@deniak deniak deleted the patch-1 branch February 26, 2024 07:06
@deniak
Copy link
Contributor Author

deniak commented Feb 26, 2024

Thanks @wolfy1339

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Feb 27, 2024
wolfy1339 added a commit to octokit/plugin-throttling.js that referenced this pull request Feb 27, 2024
Some tools don't play well with only having the `exports` field present.
See octokit/core.js#662
wolfy1339 added a commit to octokit/plugin-rest-endpoint-methods.js that referenced this pull request Feb 27, 2024
Some tools don't play well with only having the `exports` field present.

See octokit/core.js#662
wolfy1339 added a commit to octokit/request-error.js that referenced this pull request Feb 27, 2024
Some tools don't play well with only having the `exports` field present.

See octokit/core.js#662
wolfy1339 added a commit to octokit/graphql.js that referenced this pull request Feb 27, 2024
Some tools don't play well with only having the `exports` field present.

See octokit/core.js#662
wolfy1339 added a commit to octokit/auth-token.js that referenced this pull request Feb 27, 2024
Some tools don't play well with only having the `exports` field present.

See octokit/core.js#662
wolfy1339 added a commit to octokit/oauth-app.js that referenced this pull request Feb 27, 2024
Some tools don't play well with only having the `exports` field present.

See octokit/core.js#662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants