Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @octokit/tsconfig to v4 #646

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 24, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@octokit/tsconfig ^3.0.0 -> ^4.0.0 age adoption passing confidence

Release Notes

octokit/tsconfig (@​octokit/tsconfig)

v4.0.0

Compare Source

Features
BREAKING CHANGES
  • Required, but potentially undefined does not have the same intent as optional. This
    rule will enforce us to be explicit in our type declarations and how we expect octokit APIs should
    be used.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Sep 24, 2024
@oscard0m oscard0m self-assigned this Sep 24, 2024
@oscard0m oscard0m force-pushed the renovate/major-octokit-monorepo branch from 09e28c3 to b6682cc Compare September 24, 2024 20:18
src/types.ts Outdated Show resolved Hide resolved
Copy link
Contributor Author

renovate bot commented Sep 24, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@oscard0m
Copy link
Member

Relates to octokit/tsconfig#29 (comment)


Before the change?

  • We were testing types without --exactOptionalPropertyTypes option

After the change?

  • We start testing types with --exactOptionalPropertyTypes option

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@oscard0m oscard0m requested review from wolfy1339 and removed request for wolfy1339 September 24, 2024 22:25
@wolfy1339 wolfy1339 merged commit 2a11fbd into main Sep 24, 2024
12 checks passed
@wolfy1339 wolfy1339 deleted the renovate/major-octokit-monorepo branch September 24, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants