Try to solve some timeout issue

[harryzcy]

Resolves #ISSUE_NUMBER

Split the test handle 401 in first 5 seconds to two separate tests.

Try to fix errors in PR #580

---

Before the change?

After the change?

Pull request checklist

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes
• No

---

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[harryzcy]

@wolfy1339 It seems the test only timeouts when it's always a 401 response. If it's eventually 200, the test will pass

[harryzcy]

Looks like timeSinceTokenCreationInMs is always 0. So it always does the retries. Maybe Date is locked?

// src/hook.ts
const timeSinceTokenCreationInMs = +new Date() - +new Date(createdAt);

[wolfy1339]

Date is being overridden by @sinonjs/fake-timers, which is intended. However it shouldn't stay at 0, it should increment by the time argument passed to clock.tickAsync()

[harryzcy]

Date is being overridden by @sinonjs/fake-timers, which is intended. However it shouldn't stay at 0, it should increment by the time argument passed to clock.tickAsync()

I don't quite know how createdAt will be non-zero. Do you have any idea why?

[wolfy1339]

in this case, createdAt should be zero, that is the intended behaviour. The mock Date is set to 0, and we increment the clock after creating the token

[harryzcy]

in this case, createdAt should be zero, that is the intended behaviour. The mock Date is set to 0, and we increment the clock after creating the token

Looking at the log hooks.ts:123 date: 6000, createdAt:6000, timeSince: 0, >=5s: false. The start time be 6000 in the test auth.hook(): fail with 401 after 5 seconds. So we never reach the points that Date difference exceeds 5 seconds.

[wolfy1339]

@gr2m Might know more