Check if email subject set in closure #1665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If subject setted in template, changing in closure like:
Mail::queue("template", [], function ($message) use ($subject, $email) {
$message->subject($subject)->to($email);
});
has no effect.
daftspunk
added a commit
to octobercms/library
that referenced
this pull request
Jan 2, 2016
|
Merged in 922cf30 Thanks |
daftspunk
added a commit
to octoberrain/system
that referenced
this pull request
Jan 2, 2016
LukeTowers
pushed a commit
to octoberrain/system
that referenced
this pull request
Apr 20, 2019
LukeTowers
added a commit
to octobercms/library
that referenced
this pull request
Oct 5, 2019
Accomplishes this by firing the message callback before content is added to the message. This fixes an issue where subjects set on the message object through the callback were not able to override a mail template's subject as they're supposed to in System\Classes\MailManager because the callback was called after the MailManager's listener for mailer.beforeAddContent had already fired. The original issue was reported and fixed in octobercms/october#1665. However, that fix was then later broken by f409ad4 which was for the L5.5 upgrade in Build 420. It's also worth noting that Laravel has moved the callback to be before the content is added starting in L5.6, so this change also brings us closer in line with Laravel for the future 6.0 upgrade (see laravel/framework#22995 for that commit and background information).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If subject setted in template, changing in closure like:
Mail::queue("template", [], function ($message) use ($subject, $email) {
$message->subject($subject)->to($email);
});
has no effect.