[compiler] [build-fs] Fix target not set error
#1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We keep the case as to not to disturbe the printing, but not sure it is worth it.
Regression from ocsigen#1655 . Not sure if `Config.target` should be better handled as a parameter?
This has been discussed in #1655. We already have similar situation with other configs. I'd rather solve the general issue all at once, instead of solving one specific case. |
|
IMO this doesn't need a changes entry, but happy to add one. |
|
This PR means that we currently don't have any test running this command. Would you mind adding one ? Maybe in https://github.com/ocsigen/js_of_ocaml/blob/master/compiler/tests-full/dune ? |
ejgallego
added a commit
to ejgallego/js_of_ocaml
that referenced
this pull request
Sep 28, 2024
ejgallego
added a commit
to ejgallego/js_of_ocaml
that referenced
this pull request
Sep 28, 2024
ejgallego
force-pushed
the
fix_build_fs_target
branch
from
6817cc6
to
813e015
Compare
|
Done. |
ejgallego
force-pushed
the
fix_build_fs_target
branch
from
813e015
to
10847ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #1655 .
Not sure if
Config.targetshould be better handled as a parameter?