Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output UTF8-HTML-files by default and show args.minscale when skipping args #312

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Output UTF8-HTML-files by default and show args.minscale when skipping args #312

wants to merge 3 commits into from

Conversation

NormanTUD
Copy link

No description provided.

@zuphilip
Copy link
Collaborator

zuphilip commented Sep 1, 2018

@NormanTUD Looks okay in general. How about the overview page in ocropus-visualize-results, add the UTF8 part there as well?

@NormanTUD
Copy link
Author

Also use UTF8-Output for ocropus-visualize-results

@NormanTUD NormanTUD closed this Sep 6, 2018
@NormanTUD NormanTUD reopened this Sep 6, 2018
@zuphilip
Copy link
Collaborator

Ah, sorry for the delay. I think here before this block you have to include a line about UTF8 as well: https://github.com/tmbdev/ocropy/blob/65b14307f1dbd3b55006457f6babebdf20cdde9d/ocropus-visualize-results#L102-L107

kba
kba approved these changes Jan 14, 2019
View reviewed changes
Copy link
Collaborator

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, more for the fix in gpageseg than the UTF-8 header (which is still invalid HTML since body tags are missing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NormanTUD @zuphilip @kba