Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update characters for training #188

Merged
merged 3 commits into from
Mar 10, 2017
Merged

Update characters for training #188

merged 3 commits into from
Mar 10, 2017

Conversation

zuphilip
Copy link
Collaborator

@zuphilip zuphilip commented Mar 8, 2017

This is a rebase and extension of #71 by @denydias.

@denydias
Copy link
Contributor

denydias commented Mar 9, 2017

Looking good to me. Just remember to remove that 'ª' as per #71 (this comment) before the final merge.

@zuphilip
Copy link
Collaborator Author

zuphilip commented Mar 9, 2017

I already removed this little superscripted a in 38addd3 which is part of this PR.

@denydias
Copy link
Contributor

denydias commented Mar 9, 2017

Oh, sure @zuphilip! Sorry for the noise.

@zuphilip
Copy link
Collaborator Author

zuphilip commented Mar 9, 2017

No problem. I appreciate any checking.

The travis test passed, but that does not include the training. Thus, it would be good to test the training is still working the same or better for Portuguese documents. After that I will merge.

@zuphilip
Copy link
Collaborator Author

I successfully tested the training. Good for merging now.

@zuphilip zuphilip merged commit 0ee8c1b into master Mar 10, 2017
@zuphilip zuphilip deleted the characters branch March 10, 2017 22:37
@zuphilip
Copy link
Collaborator Author

Thank you very much @denydias !

@denydias
Copy link
Contributor

You're more than welcome, @zuphilip! It's a honor to have a small piece of code in this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants