-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py3k: Use print function instead of statement #155
Conversation
👍 Looks good in general, will test later.
Does not really hurt to have an extra folder with source code, makes it easier to search and understand dead code and it can be useful to dig around in there to understand the development. For me documentation, cleaning up working code and testing is more important, deleting OLD is up to @tmbdev. I wouldn't fix code in OLD though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
counter = self.computeNGraphs(fnames,n) | ||
print "got",sum(counter.values()),"%d-graphs"%(n,) | ||
print("got", sum(counter.values()), "%d-graphs" % (n, )) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks strange: After the last comma there is nothing but the closing parenthesis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a tuple.
Thank you very much @QuLogic ! Sorry for the delay. |
I split this out of #114 for easier review.
There are some changes to OLD because they were there originally, but I assume there's no need to really update the rest of them. Though I wonder why you don't just delete those files? That's why you've got git history...