Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3k: Use print function instead of statement #155

Merged
merged 1 commit into from
Jan 23, 2017

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Nov 15, 2016

I split this out of #114 for easier review.

There are some changes to OLD because they were there originally, but I assume there's no need to really update the rest of them. Though I wonder why you don't just delete those files? That's why you've got git history...

@kba
Copy link
Collaborator

kba commented Nov 15, 2016

👍 Looks good in general, will test later.

There are some changes to OLD because they were there originally, but I assume there's no need to really update the rest of them. Though I wonder why you don't just delete those files? That's why you've got git history...

Does not really hurt to have an extra folder with source code, makes it easier to search and understand dead code and it can be useful to dig around in there to understand the development. For me documentation, cleaning up working code and testing is more important, deleting OLD is up to @tmbdev. I wouldn't fix code in OLD though.

Copy link
Collaborator

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and passes both CircleCI and Travis

@zuphilip zuphilip changed the title py3k: Use print function instead of statement. py3k: Use print function instead of statement Nov 20, 2016
counter = self.computeNGraphs(fnames,n)
print "got",sum(counter.values()),"%d-graphs"%(n,)
print("got", sum(counter.values()), "%d-graphs" % (n, ))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks strange: After the last comma there is nothing but the closing parenthesis.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a tuple.

@kba kba merged commit 2e62b8e into ocropus-archive:master Jan 23, 2017
@zuphilip
Copy link
Collaborator

Thank you very much @QuLogic ! Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants