Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance advice to match --fast-web-view documentation #1206

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Fix performance advice to match --fast-web-view documentation #1206

merged 1 commit into from
Dec 17, 2023

Conversation

Androbin
Copy link
Contributor

@Androbin Androbin commented Dec 16, 2023

The current performance advice does not match the documentation of the flag:

--fast-web-view MEGABYTES
If the size of file is more than this threshold (in MB), then linearize the PDF for fast web viewing. This allows the PDF to be displayed before it is fully downloaded in web browsers, but increases the space required slightly. By default we skip this for small files which do not benefit. If the threshold is 0 it will be apply to all files. Set the threshold very high to disable.

@Androbin Androbin changed the title Fix --fast-web-view documentation Fix performance advice to match --fast-web-view documentation Dec 16, 2023
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9489c01) 90.29% compared to head (7702d01) 90.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
- Coverage   90.29%   90.24%   -0.05%     
==========================================
  Files          94       94              
  Lines        6830     6830              
  Branches     1224     1224              
==========================================
- Hits         6167     6164       -3     
- Misses        463      465       +2     
- Partials      200      201       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbarlow83 jbarlow83 merged commit 63d87fc into ocrmypdf:main Dec 17, 2023
16 of 17 checks passed
@Androbin Androbin deleted the patch-1 branch December 18, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants