Backends: SDL2: use SDL_Vulkan_GetDrawableSize with Vulkan instead of SDL_GL_GetDrawableSize

[scribam]

Follow-up for issue #3190

Currently, when using Vulkan, SDL_GL_GetDrawableSize will call SDL_GetWindowSizeInPixels (since GL_GetDrawableSize is NULL).
This works fine except on Cocoa, KMSDRM and UiKit as they have a Vulkan_GetDrawableSize defined and so they don't call SDL_GetWindowSizeInPixels. That's why SDL_Vulkan_GetDrawableSize is required instead of SDL_GL_GetDrawableSize

void SDL_GL_GetDrawableSize(SDL_Window * window, int *w, int *h)
{
    CHECK_WINDOW_MAGIC(window, );

    if (_this->GL_GetDrawableSize) {
        _this->GL_GetDrawableSize(_this, window, w, h);
    } else {
        SDL_GetWindowSizeInPixels(window, w, h);
    }
}
[...]
void SDL_Vulkan_GetDrawableSize(SDL_Window *window, int *w, int *h)
{
    CHECK_WINDOW_MAGIC(window, );

    if (_this->Vulkan_GetDrawableSize) {
        _this->Vulkan_GetDrawableSize(_this, window, w, h);
    } else {
        SDL_GetWindowSizeInPixels(window, w, h);
    }
}

device->Vulkan_GetDrawableSize = UIKit_Vulkan_GetDrawableSize;

device->Vulkan_GetDrawableSize = KMSDRM_Vulkan_GetDrawableSize;

device->Vulkan_GetDrawableSize = UIKit_Vulkan_GetDrawableSize;

Sources:

• https://github.com/libsdl-org/SDL/blob/9519b9916cd29a14587af0507292f2bd31dd5752/src/video/SDL_video.c#L4156-L4165
• https://github.com/libsdl-org/SDL/blob/9519b9916cd29a14587af0507292f2bd31dd5752/src/video/SDL_video.c#L4743-L4752
• https://github.com/libsdl-org/SDL/blob/9519b9916cd29a14587af0507292f2bd31dd5752/src/video/uikit/SDL_uikitvideo.m#L133
• https://github.com/libsdl-org/SDL/blob/9519b9916cd29a14587af0507292f2bd31dd5752/src/video/kmsdrm/SDL_kmsdrmvideo.c#L299
• https://github.com/libsdl-org/SDL/blob/9519b9916cd29a14587af0507292f2bd31dd5752/src/video/cocoa/SDL_cocoavideo.m#L158

[ocornut]

Thank you. I’ll look at this tomorrow but can you confirm it is intentional that you are testing for two different defines?

Would the SDL3 backend require the same change?

[scribam]

Thank you. I’ll look at this tomorrow but can you confirm it is intentional that you are testing for two different defines?

This was a mistake, fixed.

Would the SDL3 backend require the same change?

No, SDL_GL_GetDrawableSize and SDL_Vulkan_GetDrawableSize have been removed with SDL3, SDL_GetWindowSizeInPixels must be used (which is currently the case).

[ocornut]

Merged as 4236bc0, thank you!