-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing right & bottom table outer borders when inside a window without padding (1.90 regression) #7428
Labels
Comments
cfillion
added a commit
to cfillion/imgui
that referenced
this issue
Apr 12, 2024
…by one" This reverts commit a340718, fixes ocornut#7428.
cfillion
added a commit
to cfillion/imgui
that referenced
this issue
Apr 14, 2024
…by one" This reverts commit a340718, fixes ocornut#7428.
cfillion
added a commit
to cfillion/imgui
that referenced
this issue
May 8, 2024
…by one" This reverts commit a340718, fixes ocornut#7428.
cfillion
added a commit
to cfillion/imgui
that referenced
this issue
Jun 13, 2024
…by one" This reverts commit a340718, fixes ocornut#7428.
cfillion
added a commit
to cfillion/imgui
that referenced
this issue
Jul 3, 2024
…by one" This reverts commit a340718, fixes ocornut#7428.
JVital2013
added a commit
to SatDump/SatDump
that referenced
this issue
Jul 22, 2024
Uses the commit from ocornut/imgui#7428 to work around table borders being clipped when filling the space in child windows. This is the 2nd patch we made to ImGui (the first one being 51970f0)
You win :) |
Pushed new fix 864a2bf |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version/Branch of Dear ImGui:
1.90 - 1.90.4, since a340718
Back-ends:
Tested with example_glfw_metal, example_glfw_opengl3 & custom
Compiler, OS:
macOS
Full config/build information:
No response
Details:
Commit a340718 (1.90) draws the bottom and right borders of tables offset by 1px, beyond the expected area and potentially past the window's clip rect.
They're invisible when the table spans all available space within a child window or a normal window with no padding.
BeginTable(outer_size = ImVec2(100, 100))
produces a 101x101px table.Screenshots/Video:
Invisible/clipped borders:
1px bigger than child window borders and item frames = invading into window padding and item spacing:
(Zoomed 3x)
Minimal, Complete and Verifiable Example code:
The text was updated successfully, but these errors were encountered: