New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an API to free texture descritpors allocated by Vulkan backend #5738

Closed

azonenberg opened this issue Sep 30, 2022 · 3 comments

Labels

backends vulkan

Contributor

azonenberg commented Sep 30, 2022

Right now, there is an ImGui_ImplXXX_AddTexture function, but there doesn't appear to be a corresponding function to free a texture you don't need anymore without making raw platform API calls (e.g. vkFreeDescriptorSets) yourself.

ocornut added the backends label

Owner

ocornut commented Oct 3, 2022

The ImGui_ImplVulkan_AddTexture() function is a peculiarity of the Vulkan backend (see #914) and is already close to being a raw platform API call.

Can you confirm that calling vkFreeDescriptorSets(g_Device, g_DescriptorPool, 1, &descriptor_set); would work and be enough here? We could potentially wrap it.

The function names are misleading and handling of ImTextureID for Vulkan may evolve.

ocornut added the vulkan label

Contributor Author

azonenberg commented Oct 3, 2022

Yes, this is how I do things in my code now. It just seems weird to have one end wrapped and not the other.

ocornut changed the title ~~Feature request: Provide an API to free texture handles allocated by ImGui~~ Provide an API to free texture descritpors allocated by Vulkan backend

Owner

ocornut commented Oct 4, 2022

Added a588f00

ocornut closed this as completed

ocornut added a commit that referenced this issue


          Backends: Vulkan: Added experimental ImGui_ImplVulkan_RemoveTexture()…

a588f00

… for api symetry. (#914, #5738).

ocornut added a commit that referenced this issue


          Backends: Vulkan: Fix building with VK_NO_PROTOTYPES. (#914, #5738).

282b2b5

Amend a588f00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment