Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DragDropTarget clipping issue #4281

Closed
skaarj1989 opened this issue Jun 29, 2021 · 3 comments
Closed

DragDropTarget clipping issue #4281

skaarj1989 opened this issue Jun 29, 2021 · 3 comments
Labels
drag drop drag and drop

Comments

@skaarj1989
Copy link

Version/Branch of Dear ImGui:

Version: 1.84 WIP (18308)
Branch: docking

Back-end/Renderer/Compiler/OS

Back-ends: All of them

My Issue/Question:

A border around a drop target is drawn outside a window. I am not sure if this is expected behavior but it looks weird to me.

Screenshots/Video

image

Standalone, minimal, complete and verifiable example:

Demo -> Widgets -> Drag and Drop
@ocornut ocornut added the drag drop drag and drop label Jun 29, 2021
rokups added a commit to rokups/imgui that referenced this issue Jun 30, 2021
@rokups
Drag and Drop: Fix drop target preview not being clipped correctly. (o…
5a603b3 
…cornut#4281)
ocornut added a commit that referenced this issue Jun 30, 2021
@ocornut
Drag and Drop: drop target highlight doesn't try to bypass host clipp…
4ddb6b4 
…ing rectangle. (#4281, #3272)

Revert 4b94738
@ocornut
Copy link
Owner

ocornut commented Jun 30, 2021

Pushed a fix with 4ddb6b4
This intentional (see initial commit 4b94738) but I frankly can't remember nor understand why I thought it was a good idea back then...
Same issue as #3272

@ocornut ocornut closed this as completed Jun 30, 2021
@ocornut ocornut mentioned this issue Jun 30, 2021
Closed
ocornut added a commit that referenced this issue Oct 5, 2023
@ocornut
Drag and Drop: Rework drop target highlight. (#4281, #3272)
085ed7b 
Amend 4ddb6b4, 4b94738
@ocornut
Copy link
Owner

ocornut commented Oct 5, 2023

I have reworked this with 085ed7b

Before June 2021
image

June 2021
image

October 2023
image

@ocornut ocornut mentioned this issue Nov 22, 2023
Closed
@ocornut
Copy link
Owner

ocornut commented Nov 22, 2023 •
edited
Loading

This raised an issue, see #7049
EDIT Pushed fix bce4db0

ocornut added a commit that referenced this issue Nov 22, 2023
@ocornut
Drag and Drop: Fixed drop target highlight on items temporarily pushi…
bce4db0 
…ng a widened clip rect. (#7049, #4281, #3272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
drag drop drag and drop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ocornut @skaarj1989