Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HUSKY=0 on github installs #702

Merged
merged 8 commits into from
Nov 6, 2023
Merged

fix: HUSKY=0 on github installs #702

merged 8 commits into from
Nov 6, 2023

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Nov 2, 2023 •
edited
Loading

  • Add HUSKY=0 env var during yarn executions to avoid husky failures
  • Only compile plugin after install if it's ESM && tsconfig.json exists.

QA

use nightly sf since that will have the version of oclif/core that can auto-transpile CJS-github plugins

  • sf plugins install oclif/version, sf version
  • sf plugins install mdonnalley/plugin-dummy, sf hello world

@mdonnalley mdonnalley added the bug label Nov 2, 2023
@git2gus Git2Gus
Copy link

git2gus bot commented Nov 2, 2023

This issue has been linked to a new work item: W-14415067

@mdonnalley mdonnalley changed the title fix: --ignore-scripts on github installs fix: HSUKY=0 on github installs Nov 6, 2023
@mdonnalley mdonnalley changed the title fix: HSUKY=0 on github installs fix: HUSKY=0 on github installs Nov 6, 2023
@mshanemc mshanemc merged commit 69129c9 into main Nov 6, 2023
12 checks passed
@mshanemc mshanemc deleted the mdonnalley/github-installs branch November 6, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshanemc mshanemc mshanemc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdonnalley @mshanemc