This repository was archived by the owner on Aug 22, 2023. It is now read-only.
fix: Handle misformed error response (without stack)
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @jperasmus to sign the Salesforce.com Contributor License Agreement. |
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
- Coverage 74.41% 70.54% -3.88%
==========================================
Files 7 7
Lines 129 129
Branches 30 31 +1
==========================================
- Hits 96 91 -5
- Misses 24 27 +3
- Partials 9 11 +2
Continue to review full report at Codecov.
|
jdx
approved these changes
May 21, 2018
oclif-bot
added a commit
that referenced
this pull request
May 21, 2018
<a name="1.1.2"></a> ## [1.1.2](ca758e6...v1.1.2) (2018-05-21) ### Bug Fixes * Handle misformed error response (without `stack`) ([#8](#8)) ([9ae1790](9ae1790))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small fix.
The
clean-stackmodule always expects a string to be passed in as the first argument, otherwise, it falls apart trying to run.replace()onundefined.I understand that this module also assumes that it will receive nothing or a properly formatted Error object, but I've run into a situation where because of another third party module (
bitbucket-api-v2), it receives a plain object and not an error object. This small fix just ensures that the error gets passed along without issues.