Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

fix: Handle misformed error response (without stack) #8

Merged
merged 4 commits into from
May 21, 2018

Conversation

jperasmus
Copy link
Contributor

Very small fix.

The clean-stack module always expects a string to be passed in as the first argument, otherwise, it falls apart trying to run .replace() on undefined.

I understand that this module also assumes that it will receive nothing or a properly formatted Error object, but I've run into a situation where because of another third party module (bitbucket-api-v2), it receives a plain object and not an error object. This small fix just ensures that the error gets passed along without issues.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @jperasmus to sign the Salesforce.com Contributor License Agreement.

@codecov
Copy link

codecov bot commented May 21, 2018

Codecov Report

Merging #8 into master will decrease coverage by 3.87%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   74.41%   70.54%   -3.88%     
==========================================
  Files           7        7              
  Lines         129      129              
  Branches       30       31       +1     
==========================================
- Hits           96       91       -5     
- Misses         24       27       +3     
- Partials        9       11       +2
Impacted Files Coverage Δ
src/handle.ts 73.68% <100%> (ø) ⬆️
src/screen.ts 36.36% <0%> (-27.28%) ⬇️
src/errors/cli.ts 75.75% <0%> (-6.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b2119f...8ac1c84. Read the comment docs.

@jdx jdx merged commit 9ae1790 into oclif:master May 21, 2018
oclif-bot added a commit that referenced this pull request May 21, 2018
<a name="1.1.2"></a>
## [1.1.2](ca758e6...v1.1.2) (2018-05-21)

### Bug Fixes

* Handle misformed error response (without `stack`) ([#8](#8)) ([9ae1790](9ae1790))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants