fix: Handle misformed error response (without stack) (#8)

* fix: Handle misformed error response (without `stack`) * test: Add test for POJO input * test: Remove unused variable * lint: Style fix
oclif · May 21, 2018 · 9ae1790 · 9ae1790
1 parent 0b2119f
commit 9ae1790
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/handle.ts b/src/handle.ts
@@ -8,7 +8,7 @@ export const handle = (err: any) => {
   try {
     if (!err) err = new Error('no error?')
     if (err.message === 'SIGINT') process.exit(1)
-    let stack = clean(err.stack, {pretty: true})
+    let stack = clean(err.stack || '', {pretty: true})
     let message = stack
     if (err.oclif && typeof err.render === 'function') message = err.render()
     if (message) console.error(message)

diff --git a/test/handle.test.ts b/test/handle.test.ts
@@ -36,6 +36,14 @@ describe('handle', () => {
     expect(process.exitCode).to.equal(1)
   })
 
+  fancy
+  .stderr()
+  .finally(() => delete process.exitCode)
+  .it('handles a badly formed error object', () => {
+    handle({status: 400})
+    expect(process.exitCode).to.equal(1)
+  })
+
   fancy
   .stderr()
   .finally(() => delete process.exitCode)