Fix: remove program from config without 'program:' prefix #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A program in the entries is started with "program:", so if the prefix "program:" is removed, the program can't be removed. |
|
@ochinchina have you tested your program when reload all programs? I committed this issue because I test that case and find this bug. And then I give a solution. |
|
@AlexStocks After testing, there is a bug for the program management in the Config class. The key for a program in the entries should start with "program:" but it is missing. So if you can help to fix this bug by add "program:" prefix for a program in the entries. |
|
It's my honour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a fatal bug: remove program from config just by its program name without 'program:' prefix