#118: Process.isRunning is incorrect

ochinchina · Jan 26, 2019 · df96aae · df96aae
1 parent c6e9d46
commit df96aae
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/process/process.go b/process/process.go
@@ -11,6 +11,7 @@ import (
 	"os"
 	"os/exec"
 	"os/user"
+    "runtime"
 	"strconv"
 	"strings"
 	"sync"
@@ -327,7 +328,12 @@ func (p *Process) getExitCodes() []int {
 //
 func (p *Process) isRunning() bool {
 	if p.cmd != nil && p.cmd.ProcessState != nil {
-        return p.cmd.Process.Signal( syscall.Signal( 0 ) ) == nil
+        if runtime.GOOS == "windows" {
+            proc, err := os.FindProcess( p.cmd.Process.Pid )
+            return proc != nil && err == nil
+        } else {
+            return p.cmd.Process.Signal( syscall.Signal( 0 ) ) == nil
+        }
 	}
 	return false
 }