Add min max fields to Histogram

Fixes open-telemetry#2582
ocelotl · Jun 13, 2022 · ce00441 · ce00441
1 parent 6e282d2
commit ce00441
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/...er-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/metric_exporter/__init__.py b/...er-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/metric_exporter/__init__.py
@@ -146,6 +146,8 @@ def _translate_data(
                                 sum=data_point.sum,
                                 bucket_counts=data_point.bucket_counts,
                                 explicit_bounds=data_point.explicit_bounds,
+                                max=data_point.max,
+                                min=data_point.min,
                             )
                             pb2_metric.histogram.aggregation_temporality = (
                                 metric.data.aggregation_temporality

diff --git a/exporter/opentelemetry-exporter-otlp-proto-grpc/tests/metrics/test_otlp_metrics_exporter.py b/exporter/opentelemetry-exporter-otlp-proto-grpc/tests/metrics/test_otlp_metrics_exporter.py
@@ -720,6 +720,8 @@ def test_translate_histogram(self):
                                                 explicit_bounds=[10.0, 20.0],
                                                 exemplars=[],
                                                 flags=pb2.DataPointFlags.FLAG_NONE,
+                                                max=18.0,
+                                                min=8.0,
                                             )
                                         ],
                                         aggregation_temporality=AggregationTemporality.DELTA,
@@ -736,6 +738,7 @@ def test_translate_histogram(self):
         self.assertEqual(expected, actual)
 
     def test_translate_multiple_scope_histogram(self):
+        self.maxDiff = None
         expected = ExportMetricsServiceRequest(
             resource_metrics=[
                 pb2.ResourceMetrics(
@@ -782,6 +785,8 @@ def test_translate_multiple_scope_histogram(self):
                                                 explicit_bounds=[10.0, 20.0],
                                                 exemplars=[],
                                                 flags=pb2.DataPointFlags.FLAG_NONE,
+                                                max=18.0,
+                                                min=8.0,
                                             )
                                         ],
                                         aggregation_temporality=AggregationTemporality.DELTA,
@@ -816,6 +821,8 @@ def test_translate_multiple_scope_histogram(self):
                                                 explicit_bounds=[10.0, 20.0],
                                                 exemplars=[],
                                                 flags=pb2.DataPointFlags.FLAG_NONE,
+                                                max=18.0,
+                                                min=8.0,
                                             )
                                         ],
                                         aggregation_temporality=AggregationTemporality.DELTA,
@@ -857,6 +864,8 @@ def test_translate_multiple_scope_histogram(self):
                                                 explicit_bounds=[10.0, 20.0],
                                                 exemplars=[],
                                                 flags=pb2.DataPointFlags.FLAG_NONE,
+                                                max=18.0,
+                                                min=8.0,
                                             )
                                         ],
                                         aggregation_temporality=AggregationTemporality.DELTA,
@@ -898,6 +907,8 @@ def test_translate_multiple_scope_histogram(self):
                                                 explicit_bounds=[10.0, 20.0],
                                                 exemplars=[],
                                                 flags=pb2.DataPointFlags.FLAG_NONE,
+                                                max=18.0,
+                                                min=8.0,
                                             )
                                         ],
                                         aggregation_temporality=AggregationTemporality.DELTA,