Fix #633: Problem: cryptic Provider log messages

ocean_provider/file_types/file_types.py

@@ -117,6 +117,7 @@ def __init__(
         userdata=None,
     ) -> None:
         self.url = url
+        self.query = query
         self.userdata = {"query": query}
         if userdata:
             self.userdata["variables"] = (
@@ -131,6 +132,8 @@ def __init__(
     def validate_dict(self) -> Tuple[bool, Any]:
         if not self.url:
             return False, "missing graphql endpoint"
+        if not self.query:
+            return False, "missing graphql query"
 
         return True, self
 

ocean_provider/file_types/file_types_factory.py

@@ -59,8 +59,13 @@ def validate_and_create(file_obj) -> Tuple[bool, Any]:
                     userdata=file_obj.get("userdata"),
                 )
             else:
+                logger.debug(f"Unsupported type {file_obj}")
                 return False, f'Unsupported type {file_obj["type"]}'
         except TypeError:
+            logger.debug(f"malformed file object {file_obj}")
             return False, "malformed file object."
-
-        return instance.validate_dict()
+        status = instance.validate_dict()
+        if not status:
+            logger.debug(f"validate_dict failed on {file_obj}")
+        logger.debug(f"validate_dict passed on {file_obj}")
+        return status

ocean_provider/routes/README.md

@@ -346,6 +346,7 @@ The following table shows the keys inside a file structure:
 | hash | YES | `ipfs` | malformed service files, missing required keys. | |
 | transactionId | YES | `arwave` | malformed service files, missing transactionId | |
 | url | YES | `graphql` | missing graphql endpoint | |
+| query | YES | `graphql` | missing graphql query | |
 
 
 If no ARWEAVE_GATEWAY is defined in Provider, downloads of arweave files will fail with a 503 status code.

ocean_provider/routes/consume.py

@@ -126,6 +126,7 @@ def fileinfo():
     files_info = []
     for i, file in enumerate(files_list):
         file["userdata"] = data.get("userdata")
+        logger.debug(f"Validating :{file}")
         valid, message = FilesTypeFactory.validate_and_create(file)
         if not valid:
             return error_response(message, 400, logger)