-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch nodev20 support #80
Conversation
btw, its better if you have 'nvm' already installed, since there is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe worth pulling CODEOWNERS commit from main and adding more handles so we all get notifications when PR's are ready fro review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are still using node 16 :)
@paulo-ocean Here's a solution, but it requires an additional parameter in Node startup and most likely @alexcos20 will not approve this option https://github.com/nodejs/loaders-test/tree/main/commonjs-extension-resolution-loader |
thanks @an7e |
I've already updated it, but PR is still blocked |
Fixes #79 .
Changes proposed in this PR: