Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have bootstrap config var #782

Merged
merged 2 commits into from
Dec 5, 2024
Merged

have bootstrap config var #782

merged 2 commits into from
Dec 5, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Dec 5, 2024 •
edited
Loading

Fixes #781

Changes proposed in this PR:

  • disables handling of commands if is configured as bootstrap node

alexcos20
alexcos20 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean marked this pull request as ready for review December 5, 2024 14:49
jamiehewitt15
jamiehewitt15 reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally it should also be added to docs/env.md

@paulo-ocean paulo-ocean changed the title have bootsrap config var have bootstrap config var Dec 5, 2024
@paulo-ocean
Copy link
Contributor Author

Ideally it should also be added to docs/env.md

of course, just wanted to get this out asap :-)

jamiehewitt15
jamiehewitt15 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's not forget to add this to the docs as well

@paulo-ocean
Copy link
Contributor Author

Looks good to me. Let's not forget to add this to the docs as well

1 min

@paulo-ocean paulo-ocean merged commit ab4547b into main Dec 5, 2024
10 of 11 checks passed
@paulo-ocean paulo-ocean deleted the issue-781-disable-cmd branch December 5, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 alexcos20 approved these changes

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove handle of commands from bootstrap nodes
3 participants
@paulo-ocean @alexcos20 @jamiehewitt15