Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unused express dependency from dashboard #761

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Removing unused express dependency from dashboard #761

merged 3 commits into from
Dec 2, 2024

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented Nov 26, 2024 •
edited
Loading

Fixes #760
Fixes: #765

Changes proposed in this PR:

  • Removing unused express dependency from the dashboard
  • Updating the static dashboard files

@paulo-ocean paulo-ocean mentioned this pull request Nov 26, 2024
Closed
@jamiehewitt15 jamiehewitt15 self-assigned this Nov 26, 2024
mariacarmina
mariacarmina approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamiehewitt15 jamiehewitt15 merged commit 8e1cbe2 into main Dec 2, 2024
12 checks passed
@jamiehewitt15 jamiehewitt15 deleted the issue-760-remove-express-dashboard branch December 2, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@mariacarmina mariacarmina mariacarmina approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees

@jamiehewitt15 jamiehewitt15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding docker-compose.yml to gitignore Remove Express dependency from dashboard
3 participants
@jamiehewitt15 @mariacarmina @paulo-ocean