Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if rpcs and indexer_networks are aligned, log #750

Merged
merged 3 commits into from
Nov 29, 2024
Merged

check if rpcs and indexer_networks are aligned, log #750

merged 3 commits into from
Nov 29, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Nov 12, 2024 •
edited
Loading

Fixes #728

Changes proposed in this PR:

  • make sure we at least do some logging when RPCS and INDEXER_NETWORKS have mismatches (making the node to run without indexer)

@paulo-ocean paulo-ocean marked this pull request as ready for review November 13, 2024 09:14
@paulo-ocean paulo-ocean self-assigned this Nov 15, 2024
jamiehewitt15
jamiehewitt15 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

mariacarmina
mariacarmina approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean merged commit 8358d8e into main Nov 29, 2024
12 checks passed
@paulo-ocean paulo-ocean deleted the issue-728-misleading-msg branch November 29, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariacarmina mariacarmina mariacarmina approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If RPCS and INDEXER_NETWORKS are not aligned we should show a log message
3 participants
@paulo-ocean @jamiehewitt15 @mariacarmina