Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dashboard hash out of sync #744

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix dashboard hash out of sync #744

merged 1 commit into from
Nov 6, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Oct 30, 2024 •
edited
Loading

Fixes #664

Changes proposed in this PR:

  • The dashboard hash was not updated the last time we changed something on the dashboard (+ details on issue)
  • when we update anything (any file) inside dashboard directory, we need to re-build to re-calculate the hash and commit the changes as well, sometimes we forget that

jamiehewitt15
jamiehewitt15 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean paulo-ocean self-assigned this Nov 5, 2024
@jamiehewitt15 jamiehewitt15 mentioned this pull request Nov 5, 2024
Draft
@paulo-ocean paulo-ocean merged commit 1e43f70 into main Nov 6, 2024
12 checks passed
@paulo-ocean paulo-ocean deleted the issue-664-dashboard-hash branch November 6, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariacarmina mariacarmina mariacarmina approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard files marked as modified after a simple build
3 participants
@paulo-ocean @jamiehewitt15 @mariacarmina