Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cleaner logging when idexing and getting/updating block info from db #743

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Add cleaner logging when idexing and getting/updating block info from db #743

merged 2 commits into from
Oct 30, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Oct 29, 2024 •
edited
Loading

Fixes #742 #740

Changes proposed in this PR:

  • imporve logging a bit on indexer thread (block related stuff) for clearity
  • minor refactor on a couple of functions to log and avoid dealing with 'nulls'

@paulo-ocean paulo-ocean changed the title add cleaner logging when idexing and getting/updating block info from db Add cleaner logging when idexing and getting/updating block info from db Oct 29, 2024
@paulo-ocean paulo-ocean self-assigned this Oct 30, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review October 30, 2024 09:54
jamiehewitt15
jamiehewitt15 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean paulo-ocean mentioned this pull request Oct 30, 2024
Closed
mariacarmina
mariacarmina approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean merged commit fe5544e into main Oct 30, 2024
12 checks passed
@paulo-ocean paulo-ocean deleted the issue-742-better-index-log branch October 30, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariacarmina mariacarmina mariacarmina approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve logging when start indexing chain
3 participants
@paulo-ocean @jamiehewitt15 @mariacarmina