Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version express 4.18.2 -> 4.21.0. #717

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Bump version express 4.18.2 -> 4.21.0. #717

merged 3 commits into from
Oct 16, 2024

Conversation

mariacarmina
Copy link
Member

Fixes # .

Changes proposed in this PR:

@mariacarmina mariacarmina self-assigned this Oct 14, 2024
@mariacarmina
Copy link
Member Author

Unit test failing -> Segmentation fault (core dumped)

@mariacarmina mariacarmina marked this pull request as ready for review October 14, 2024 19:42
This was referenced Oct 14, 2024
Closed
Closed
@jamiehewitt15
Copy link
Member

Unit test failing -> Segmentation fault (core dumped)

Do we know what the issue is that's causing this?

@mariacarmina mariacarmina mentioned this pull request Oct 15, 2024
Closed
@paulo-ocean
Copy link
Contributor

paulo-ocean commented Oct 15, 2024 •
edited
Loading

Unit test failing -> Segmentation fault (core dumped)

Do we know what the issue is that's causing this?

I believe its the Blockchain / RPC connection retry mechanism (when we have wrong/invalid RPCs... it can't get a proper connection and keeps recursively retrying forever... doing a new JSONRPCProvider() call .. It can kill the memory eventually
This is already addressed on the Elastic search PR (also moved outside crawler thread)... since that part was refactored (now it tries to reconnect 10 X at most)

jamiehewitt15
jamiehewitt15 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mariacarmina mariacarmina merged commit 5cb14f1 into main Oct 16, 2024
12 checks passed
@mariacarmina mariacarmina deleted the npm-update-express-4.21.0 branch October 16, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees

@mariacarmina mariacarmina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariacarmina @jamiehewitt15 @paulo-ocean