You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests failing on this PR dues to Segmentation fault error :(
Same issue already mentioned on another PR
Check these log messages: JsonRpcProvider failed to detect network and cannot start up; retry in 1s (perhaps the URL is wrong or the node is not started)
The main issue is that we have the crawler thread starting when we don't have a DB connection or a proper RPC connection (wrong behaviour)...
Inside the crawler thread we have a mechanism to retry the RPC/Blockchain connection... that can stay there forever if there is something really wrong... (it keeps retrying)... Eventually it can kill the memory...
This was already addressed on the Elastic PR..
The crawler thread should not start without a DB connection and an RPC connection ... Only after... Eventually it should not keeping retrying RPC connection forever either, but only a few times ( Max 10 times )
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mariacarmina
requested review from
alexcos20,
bogdanfazakas,
jamiehewitt15 and
paulo-ocean
as code owners
Fixes # .
Changes proposed in this PR: