Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add credentials at service level, on schemas #710

Merged
merged 7 commits into from
Oct 15, 2024
Merged

add credentials at service level, on schemas #710

merged 7 commits into from
Oct 15, 2024

Conversation

paulo-ocean
Copy link
Contributor

Fixes #709.

Changes proposed in this PR:

@paulo-ocean paulo-ocean self-assigned this Oct 7, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review October 7, 2024 17:53
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean marked this pull request as draft October 7, 2024 19:04
@paulo-ocean
Copy link
Contributor Author

gonna create a new version 4.7 and update the tests

@paulo-ocean paulo-ocean marked this pull request as ready for review October 8, 2024 08:14
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean paulo-ocean merged commit 0fb6573 into main Oct 15, 2024
12 checks passed
@paulo-ocean paulo-ocean deleted the issue-709 branch October 15, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValidateDDO fails because DDO shacl Schemas are missing 'credentials' (introduced at service level)
3 participants