Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error message, transfer fees and tweak node response #701

Merged
merged 1 commit into from
Sep 30, 2024
Merged

improve error message, transfer fees and tweak node response #701

merged 1 commit into from
Sep 30, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Sep 27, 2024 •
edited
Loading

Fixes #666 .

Changes proposed in this PR:

  • properly sets the node status message in case of errors (node)
  • shows proper/clear error message on transfer fees issues (cpanel)

@paulo-ocean paulo-ocean self-assigned this Sep 27, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review September 27, 2024 10:50
jamiehewitt15
jamiehewitt15 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean
Copy link
Contributor Author

forgot to add an ex screenshot
Screenshot from 2024-09-27 11-01-23

@alexcos20 alexcos20 merged commit c00a374 into main Sep 30, 2024
12 checks passed
@alexcos20 alexcos20 deleted the issue-666-transfer-fees-error-msg branch September 30, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 alexcos20 approved these changes

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transfer fees error messages should be more clear
3 participants
@paulo-ocean @alexcos20 @jamiehewitt15