fix default filtered p2p ip list (non routable ips that should not be announced) #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulo-ocean
requested review from
alexcos20,
bogdanfazakas,
jamiehewitt15 and
mariacarmina
as code owners
|
need to fix tests, break unit tests with 2 local nodes |
alexcos20
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Although I do not fully support this because of two reasons:
- users should learn networking, otherwise they will not understand what's happening
- this breaks complex setups, like private networks of nodes or semi private (a couple of nodes inside an interna network that are using some relay servers to protect them selves from outside)
I will approve it just because it makes life eaiser for noobies .
One small suggestion and we are good to go
src/test/unit/oceanP2P.test.ts
Outdated
| @@ -55,6 +56,7 @@ describe('OceanP2P Test', () => { | |||
| config2.p2pConfig.bootstrapNodes = [] | |||
| // enable private IP | |||
| config2.p2pConfig.announcePrivateIp = true | |||
| config1.p2pConfig.filterAnnouncedAddresses = ['172.15.0.0/24'] // allow nodes to see each other locally for tests | |||
There was a problem hiding this comment.
shouldn't be config2 ?
Suggested change
| config1.p2pConfig.filterAnnouncedAddresses = ['172.15.0.0/24'] // allow nodes to see each other locally for tests | |
| config2.p2pConfig.filterAnnouncedAddresses = ['172.15.0.0/24'] // allow nodes to see each other locally for tests |
There was a problem hiding this comment.
yeah :-) .... damn copy/paste
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #691 .
Changes proposed in this PR: