Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max ram memory in node start cmd #697

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Sep 24, 2024

Fixes # .

Changes proposed in this PR:

  • allow ocean node to use up to 28gb of ram if available instead of the default 8gb of memory

Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
but i wonder if we should change the specs/system requirements section (on the docs)
Currently we have:

- 1vcpu
- 2 GB ram
- 4 GB storage

According to the node docs we should put a lower number than the total available RAM
https://nodejs.org/api/cli.html#--max-old-space-sizesize-in-megabytes
In this case, for a 2GB RAM we are allowing the entire 2GB for garbage collection, but i guess we always have more than this anyway

@bogdanfazakas bogdanfazakas self-assigned this Sep 25, 2024
@bogdanfazakas bogdanfazakas merged commit 05662ec into main Sep 25, 2024
12 checks passed
@bogdanfazakas bogdanfazakas deleted the update-start-cmd branch September 25, 2024 08:14
@bogdanfazakas
Copy link
Member Author

lgtm but i wonder if we should change the specs/system requirements section (on the docs) Currently we have:

- 1vcpu
- 2 GB ram
- 4 GB storage

According to the node docs we should put a lower number than the total available RAM https://nodejs.org/api/cli.html#--max-old-space-sizesize-in-megabytes In this case, for a 2GB RAM we are allowing the entire 2GB for garbage collection, but i guess we always have more than this anyway

i think the specs are fine, they are related to the vm rather the node app config, so in this case the process will use around 1.5 gb of ram max , like in the eg bellow for a vm with 2gb of ram avaialble
Screenshot 2024-09-25 at 11 16 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants