Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating deprecated actions #681

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Updating deprecated actions #681

merged 4 commits into from
Sep 27, 2024

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented Sep 12, 2024 •
edited
Loading

Fixes #680

Changes proposed in this PR:

  • Updating deprecated upload-artifact@v2 action which was causing the tests to fail.
  • Updated all of the other outdated actions.

@jamiehewitt15 jamiehewitt15 changed the title Updating deprecated action Updating deprecated actions Sep 12, 2024
@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review September 12, 2024 12:56
paulo-ocean
paulo-ocean reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you need also to change the names on the dowload-artifact (2 times coverage)
(edited: this was for ocean.js, doesn't make sense here, my bad)

@alexcos20
Copy link
Member

@jamiehewitt15 - shall we merge this?

@jamiehewitt15 jamiehewitt15 merged commit 87b3428 into main Sep 27, 2024
4 checks passed
@jamiehewitt15 jamiehewitt15 deleted the issue-680-failing-test branch September 27, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit & Integration tests are failing
4 participants
@jamiehewitt15 @alexcos20 @bogdanfazakas @paulo-ocean