-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 668 oasis decryption #679
Conversation
Is there a reason you didn't add any tests? It would make it easier to check that it's working, even if they are on the live network and not included in the CI (like Maria did in her PR) |
we already have tests for the download, imo, we don't need a specific just to do an extra smart contract function call, and this is a live network so it will not be maintainable. I guess the same reason we don't have a dedicated test for all the EVMs we support :-) Also. If they are not part of the CI, what are they good for? we can just use the CLI for ex: |
added a couple of unit tests for aux functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Fixes #668
Changes proposed in this PR: