Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 668 oasis decryption #679

Merged
merged 14 commits into from
Sep 25, 2024
Merged

Issue 668 oasis decryption #679

merged 14 commits into from
Sep 25, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Sep 11, 2024

Fixes #668

Changes proposed in this PR:

  • handles template 4 (confidential EVM) download/decryption

@paulo-ocean paulo-ocean self-assigned this Sep 18, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review September 18, 2024 15:04
@jamiehewitt15
Copy link
Member

Is there a reason you didn't add any tests? It would make it easier to check that it's working, even if they are on the live network and not included in the CI (like Maria did in her PR)

@paulo-ocean
Copy link
Contributor Author

paulo-ocean commented Sep 19, 2024

Is there a reason you didn't add any tests? It would make it easier to check that it's working, even if they are on the live network and not included in the CI (like Maria did in her PR)

we already have tests for the download, imo, we don't need a specific just to do an extra smart contract function call, and this is a live network so it will not be maintainable. I guess the same reason we don't have a dedicated test for all the EVMs we support :-) Also. If they are not part of the CI, what are they good for? we can just use the CLI for ex:

@paulo-ocean
Copy link
Contributor Author

Is there a reason you didn't add any tests? It would make it easier to check that it's working, even if they are on the live network and not included in the CI (like Maria did in her PR)

we already have tests for the download, imo, we don't need a specific just to do an extra smart contract function call, and this is a live network so it will not be maintainable. I guess the same reason we don't have a dedicated test for all the EVMs we support :-) Also. If they are not part of the CI, what are they good for? we can just use the CLI for ex:

added a couple of unit tests for aux functions

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean paulo-ocean merged commit b6c14f3 into main Sep 25, 2024
12 checks passed
@paulo-ocean paulo-ocean deleted the issue-668-oasis-decryption branch September 25, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sapphire decryption
3 participants